rez
rez copied to clipboard
AcademySoftwareFoundation
fix: add platform/arch to variant for rez-pip packages with entry point scripts
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.5% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
I looked at the build failures and I'm not too sure what's going on. And our builds are being massively queued right now, which makes debugging quite difficult.
Also, you will have to sign off your commits. See https://github.com/AcademySoftwareFoundation/rez/pull/1287/checks?check_run_id=6716785034.
Hey @bpabel , can you rebase your branch with master please? That should fix the windows build issues. Thanks!
Actually, wait a little bit, we have another failure on master.
Alright, you can rebase now. The issue has been fixed and the workflow should work.
@JeanChristopheMorinPerso Cool, thanks. Rebased and updated from your notes. Looks like builds are succeeding now.
I did not have the chance to actually test myself but it looks good to me and is also an important fix (specifically on windows). At some time in the future i would like to revisit rez-pip, move to a more sensible approach to the file mapping and also add less specific variants for pure python packages without entrypoints. Good one!
