rez icon indicating copy to clipboard operation
rez copied to clipboard

Published 20 hours ago • verified publisher icon AcademySoftwareFoundation

Added the missing paths=self.package_paths

Open ColinKennedy opened this issue 3 years ago • 4 comments

Fixes: https://github.com/nerdvegas/rez/issues/1274

Added missing self.package_paths so get_resolve_diff produces correct results. This is safe to do because of the existing self.package_paths != other.package_paths check, above.

ColinKennedy avatar Apr 06 '22 05:04 ColinKennedy

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 06 '22 05:04 sonarqubecloud[bot]

This looks alright to me. Can you rebase your branch please? Rebasing should fix the Windows CI failures.

JeanChristopheMorinPerso avatar Jul 01 '22 16:07 JeanChristopheMorinPerso

@ColinKennedy See https://github.com/AcademySoftwareFoundation/rez/runs/7476834008?check_suite_focus=true.

I think the copyright text is missing in the test file you added. Or maybe we have to adjust the script...

If the script needs to be updated, let me know and I'll look into it.

JeanChristopheMorinPerso avatar Jul 22 '22 23:07 JeanChristopheMorinPerso

@JeanChristopheMorinPerso I added the copyright header manually but probably should just run the autofix script. If I run that and it still fails, I will let you know

ColinKennedy avatar Jul 23 '22 00:07 ColinKennedy