openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Redundant call to render function in vdb viewer

Open Aakash1312 opened this issue 7 years ago • 3 comments

https://github.com/dreamworksanimation/openvdb/blob/ffb02d5527379a08c07449e39d3324ac2e5eff28/openvdb/viewer/Viewer.cc#L1159

The mUpdates variable is reset at every key callback. However, I believe mUpdates should be reset only when key is pressed. Presently this variable is reset when the key is pressed as well as when it released. Due to this, the render function is called four times instead of two.

Aakash1312 avatar Oct 02 '17 15:10 Aakash1312

Hello I would like to work on this. I am a little confused. What lines of code are you referring to and what is the key?

Nivig1310 avatar Sep 12 '22 01:09 Nivig1310

Please assign this issue to me. I have already created PR for this issue.

ruchiparmar7 avatar Feb 05 '23 10:02 ruchiparmar7

Can you please assign me this issue.

ganesh1828 avatar Mar 30 '23 05:03 ganesh1828