openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Removed Redundant Render Function Call

Open ganesh1828 opened this issue 1 year ago • 3 comments

Due to mUpdates upper limit value check 2, render function is called twice from the loop in the view function in the Viewer.cc file. Changing its upper limit value check to 1 will results in calling render function only once.

ganesh1828 avatar Oct 13 '23 17:10 ganesh1828

CLA Not Signed

Rings some alarm bells for me:

  1. effectively a 1 line change, that would be "easy to approve"
  2. no description provided
  3. Why is there a binary blob committed, and then removed in a second commit? Just to place it in the history?!

smells fishy

diiigle avatar Oct 14 '23 17:10 diiigle

@diiigle Binary was pushed by mistake, that's why I removed it. and description is provided now, you can check it.

ganesh1828 avatar Oct 14 '23 19:10 ganesh1828