openvdb
openvdb copied to clipboard
AcademySoftwareFoundation
openvdb_tool: a new command-line tool that exposes most of the high-level functionalities in openvdb/tools
Signed-off-by: Ken [email protected]
A new command-line tool, dubbed vdb_tool, that can combine any sequence of the of high-level tools available in openvdb. For instance, it can convert a sequence of polygon meshes and particles to level sets, and perform a large number of operations on these level set surfaces. It can also generate adaptive polygon meshes from level sets, render images and write particles, meshes or VDBs to disk or stream VDBs to stdout so other tools can render them (using pipelining).
One general comment on the structure, looking a bit into the future if we want to use this more widely. Is there any way to pull out the actual functional stuff from the Tool.h, and have a registration system instead? This would avoid people having to modify the Tool header to add new functionality etc.
One general comment on the structure, looking a bit into the future if we want to use this more widely. Is there any way to pull out the actual functional stuff from the Tool.h, and have a registration system instead? This would avoid people having to modify the Tool header to add new functionality etc.
I'm not sure I understand your proposal/comment/concern. Adding new actions is as simple as I can imagine - add a single call-back and documentation strings. Why is it important that it's not in Tools.h? Are you suggesting run-time loading of modules? Clearly I'm missing something so please elaborate
How did you merge in master? It doesn't look like a merge commit to me and the diff in github is showing 200+ file changes
Are the .txt files instead to be read by the tool or are they just examples? is plain text the best format for this?
I've just re-merged master to fix the diff
great thanks! However, I'm not sure how to merge your changes into my clone. The second command fails for me:
git fetch upstream git merge upstream/feature/vdb_tool
I've just re-merged master to fix the diff
great thanks! However, I'm not sure how to merge your changes into my clone. The second command fails for me:
git fetch upstream git merge upstream/feature/vdb_tool
I merged the current master into your branch. Your fork should already by up to date
I don't understand why the DCO test fails! I know for a fact that I used "--signoff" with my commits. More to the point, I don't know how to resolve this issue - the guidelines for correcting this (git replace HEAD~27) fails! I assume this means an old commit (#27) was missing "--signoff"?! Does anyone know how to fix this?