openexr icon indicating copy to clipboard operation
openexr copied to clipboard

feature request: signed strides

Open claudeha opened this issue 6 years ago • 3 comments

Frame buffer slice strides are non-negative as per: https://github.com/openexr/openexr/blob/d778a0b47b18fe1ede3824fe013cea9dd7404360/OpenEXR/IlmImf/ImfFrameBuffer.h#L98-L99

Negative strides could be useful for flipping images at I/O time.

Would it be possible to change size_t to ssize_t at the next ABI-break-point?

claudeha avatar Nov 18 '19 16:11 claudeha

The TSC discussed this. It's a useful feature, implemented in other places like OIIO.

If you would entertaining making the change, we'd happily review it and consider incorporating it.

The change will require careful testing, so besides just changing the type, the test suite should include tests that validate the behavior.

cary-ilm avatar Nov 22 '19 00:11 cary-ilm

The type should probably be ptrdiff_t, right?

fnordware avatar Jan 28 '20 20:01 fnordware

We're planning a 3.0 release for later in August. If anyone from the community would like to submit a PR that address this (with sufficient testing), now would be a good time to consider including it.

cary-ilm avatar Jul 16 '20 01:07 cary-ilm