M44d/f missing rotation methods in PyIlmBase

[scott-wilson]

I noticed that the M44d and M44f in PyIlmBase are missing the setEulerAngles and setAxisAngle methods that are in the IlmBase matrix classes in the master branch. Is this intentional, or should I try my hand at setting up a pull request?

[mridullpandey]

Hey @scott-wilson i want to work on this issue kindly help

[scott-wilson]

Honestly, I only have the vaguest idea of where to start. You'll probably want to ask someone with a few more commits under their belt.

[cary-ilm]

This requires dealing with boost python, which can be challenging. The best way to approach it is to mimic what's already there. Look at the implementation of a method such as setScale, in PyImathMatrix33.cpp. Copy the various bits of code that implement setScale to implement setEulerAngles. Obviously, the guts of the function will be different, but the overall pattern of the wrapping will be similar. setAxisAngle will be a bit trickier since it takes 2 arguments, a scale and an tuple.

[devansh289]

@scott-wilson @cary-ilm Hey, if this has not been resolved yet, can I take on this issue?

[scott-wilson]

I haven't touched it. From my opinion, it's all yours

[cary-ilm]

Fine with me if you'd like to take a stab at it, although as I mention, it requires dealing with boost python, which can be confusing. The best way to approach it is to copy and paste from similar routines.