OpenTimelineIO
OpenTimelineIO copied to clipboard
WIP - Issue #1186: Add enabled Flag to Transitions
This PR fixes #1186.
Created the enabled
flag for Transition
based on what was implemented in the case of Item
.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: visajshah / name: Visaj Nirav Shah (c90830c40ecaa894539188c71e4468049f776413)
@visajshah you're the first person to use the new EasyCLA system on OpenTimelineIO since we moved the repo to ASWF. Did the process of signing the new CLA go okay? Was any of it confusing?
@visajshah you're the first person to use the new EasyCLA system on OpenTimelineIO since we moved the repo to ASWF. Did the process of signing the new CLA go okay? Was any of it confusing?
@jminor, Yes, it was easy and straightforward. No issues faced.
Could you add a unit test for this? Especially one that confirms that older OTIO files without the flag result in a Transition which is enabled. Also could you add some doc strings so that the new property have an explanation in the documentation?
Noted, @jminor. I am still working on the main issue; hence I added WIP (Work in Progress). Once done, I will also create the required tests and add to the documentation.
@visajshah GitHub supports what's called draft PRs, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft. This let's everyone know that a PR is WIP without relying on the title.
@visajshah GitHub supports what's called draft PRs, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft. This let's everyone know that a PR is WIP without relying on the title.
Thank you, @JeanChristopheMorinPerso. Done.