OpenPBR icon indicating copy to clipboard operation
OpenPBR copied to clipboard

Allow subsurface_radius_scale to go above 1

Open peterkutz opened this issue 5 months ago • 1 comments

This PR removes the upper bound on the supported range of values for subsurface_radius_scale. This lets this parameter be used to decrease the volume density, not just increase it.

peterkutz avatar Jul 29 '25 23:07 peterkutz

Should this change target a fix or a feature branch ? And is not that redundant with subsurface_radius ?

AdrienHerubel avatar Sep 30 '25 15:09 AdrienHerubel

I'm not sure I'm comfortable with the idea of this PR. Currently the subsurface_radius is supposed to define the length scale of the mean free path, with the subsurface_radius_scale applying a per-channel modulation to this. The color which is entered is similar, though not identical, to the color seen in thin areas which transmit.

It seems a bit unintuitive to allow for arbitrarily high HDR color components, since then the resulting "color" will generally have no relation to the color seen in the render. It's also redundant with the current functionality, and doesn't seem much of a convenience.

portsmouth avatar Dec 08 '25 02:12 portsmouth