OpenPBR icon indicating copy to clipboard operation
OpenPBR copied to clipboard

`transmission_dispersion_scale` -> `transmission_dispersion` ?

Open portsmouth opened this issue 5 months ago • 1 comments

This is very minor, but this name transmission_dispersion_scale seems unnecessarily long. It functions as the main slider for the dispersion effect, so why not just call it transmission_dispersion?

(Then transmission_dispersion_abbe_number gives the Abbe control. It could also be abbreviated to transmission_dispersion_abbe).

portsmouth avatar Jul 21 '25 19:07 portsmouth

Yes, this seems like a good idea. Technically, "dispersion" is already defined as the spread of the IORs across the wavelengths, so dispersion scale is redundant.

The only potential advantage of current form is that the word "scale" arguably helps clarify the 0-to-1 range of the parameter.

peterkutz avatar Jul 22 '25 17:07 peterkutz