OpenCue icon indicating copy to clipboard operation
OpenCue copied to clipboard

Load job list by default and add setting to control that behavior.

Open bcipriano opened this issue 4 years ago • 5 comments

Link the Issue(s) this Pull Request is related to. Fixes #698

Summarize your change. Beginner OpenCue users have a reasonable expectation that on launching CueGUI they will see a list of jobs currently on the farm. The current behavior doesn't do this, but requires one of the job search options to change before loading jobs. This PR changes the default behavior and causes all jobs to be loaded on startup.

For advanced OpenCue users, this behavior may not be desirable due to having a large number of jobs, so we also add a cuecommander.ini setting to allow disabling this behavior.

This PR also fixes a bug where non-matching jobs would not be cleared from the monitored job list, leading to the perceived behavior that the job search was not working.

bcipriano avatar Jul 30 '20 21:07 bcipriano

Thanks Greg, all good calls! PTAL

bcipriano avatar Aug 05 '20 20:08 bcipriano

@gregdenton Ping, does this look ok?

bcipriano avatar Aug 12 '20 19:08 bcipriano

@gregdenton Ping

bcipriano avatar Sep 02 '20 20:09 bcipriano

@gregdenton Hi Greg, could I get a final review on this please?

bcipriano avatar Sep 29 '20 20:09 bcipriano

Getting strange behaviour here. when I start up a session with finished jobs and toggle the Load Finished off I get the following traceback.

Traceback (most recent call last):
  File "/home/lars/rnd/github/OpenCue/venv/lib/python2.7/site-packages/cuegui/plugins/MonitorJobsPlugin.py", line 177, in _regexLoadJobsHandle
    self.jobMonitor.removeAllJobsExcept(matching_jobs)
  File "/home/lars/rnd/github/OpenCue/venv/lib/python2.7/site-packages/cuegui/JobMonitorTree.py", line 271, in removeAllJobsExcept
    existingItemKey = cuegui.Utils.getObjectKey(existingItem.rpcObject)
AttributeError: 'NoneType' object has no attribute 'rpcObject'

traceback

larsbijl avatar Nov 15 '20 15:11 larsbijl

Closing up stale PRs

DiegoTavares avatar May 03 '24 20:05 DiegoTavares