unbookProcs method not defined on server

[bcipriano]

spi_cue.Cue3.wrappers.layer defines a function unbookProcs. This method signature does not have any match in ICE or on the server. Verify that it is ok to remove.

[JohnWelborn]

The cuebot has an optimization (for performance and cache reuse) where a proc stays on the same layer in some cases. Users sometimes would unbook a proc if they did not like it so they could pick up another one but without killing the running frame.

Maybe its part of the proc interface? Are the old slice files available?

[gregdenton]

Thanks for the info John. I think I've found the disconnect. The original slice files defined an unbookProcs method that used a ProcSearchCriteria attribute to handle the unbooking from a job or layer object. We have this message also on grpc. However the cue python API used the proxy object of a layer or job to unbook with the following signature: layer.unbookProcs(list<Subscriptions>, number=int, kill=bool).

The single proc.unbook method is still available and working to give basic unbook support, but I suggest we add the multi unbook functionality back by simply having the layer.unbookProcs and job.unbookProcs functions construct the ProcSearchCriteria object and pass that to the existing grpc message ProcInterface.UnbookProcs.