OpenColorIO icon indicating copy to clipboard operation
OpenColorIO copied to clipboard

Release 2.1.1 and 2.1.2 from Github does not build

Open kermitdafrog8 opened this issue 2 years ago • 4 comments

Missing #include in src/OpenColorIO/FileRules.cpp

https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/06601f0e435bed79c792c2627ad19145b287ca38/src/OpenColorIO/FileRules.cpp#L6

It is included in the master branch but for some reason not in the release packages.

kermitdafrog8 avatar Jul 04 '22 16:07 kermitdafrog8

Hi @kermitdafrog8,

Can you give more details on your build environment?

remia avatar Jul 04 '22 17:07 remia

Slackware 15.0+ GCC 12.1.0 CMake 3.23.2. What other information do you need? I see the include is in the main branch but it doesn't look like it's there in the release packages here on Github.

kermitdafrog8 avatar Jul 05 '22 03:07 kermitdafrog8

@kermitdafrog8 thanks for the information, I think we missed that because our CI environments on those release branches are slightly outdated compared to main and the error only shows up on newer compilers version. I'm not sure we will have new releases any time soon, do you have the possibility to apply the required patch on your build process in the meantime?

remia avatar Jul 06 '22 08:07 remia

Yes I can make a patch file to add this in during the build process. Just wanted to make you aware of the fact that this isn't in the release packages.

kermitdafrog8 avatar Jul 06 '22 18:07 kermitdafrog8