MaterialX icon indicating copy to clipboard operation
MaterialX copied to clipboard

Color to float conversion for directional albedo in generalized_schlick_bsdf

Open niklasharrysson opened this issue 4 years ago • 0 comments

We use the color component average to convert directional albedo to a monochromatic value in generalized_schlick_bsdf.

Conversion is done to avoid getting complementary colors on the base layer. But the use of average may in some cases result in issues with energy conservation for separate color components, as noted in this PR: https://github.com/KhronosGroup/MaterialX/pull/1

A possible strategy to avoid this is to use the max value of the color components instead of the average.

We should here discuss the pros and cons of these strategies (or others?).

niklasharrysson avatar Oct 07 '21 13:10 niklasharrysson