MaterialX icon indicating copy to clipboard operation
MaterialX copied to clipboard

Graph Editor: Add UI support for enumerated values

Open kwokcb opened this issue 9 months ago • 5 comments

Issue

Enumerations are string entry fields instead of as a set of enumerations which can be selected. This makes it so users have to guess or lookup the string in spec / definitions.

Note: Every change causes a shader rebuild as well.

Proposal

Add in some basic UI such as a drop-down menu with the options pre-populated. Then the user cannot enter an invalid value and shader rebuild overhead is removed.

kwokcb avatar May 04 '25 13:05 kwokcb

Sug as possible first issue ?

kwokcb avatar May 04 '25 13:05 kwokcb

Hi , Can I pick this as first issue for upcoming Dev Days? I am a first time contributor, I have draft version of solution, will be able to refine the solution further on Dev Days.

inter-sakot4 avatar May 07 '25 21:05 inter-sakot4

Excellent, welcome @inter-sakot4!

jstone-lucasfilm avatar May 07 '25 22:05 jstone-lucasfilm

I am close to concluding this issue GraphEditor - Enum task , but I made few assumptions:

  • Fix the issue for only GraphEditor , though similar issue exist also in MaterialXView
  • Generalize the solution to int, boolean, string, float, double, Vector2, Vector3, Vector4, Color3, Color4, Matrix types

inter-sakot4 avatar May 15 '25 16:05 inter-sakot4

I think its fine to scope the work just to the GraphEditor if that makes sense for now - if thats the route you go - we may make sub-tasks for the GraphEditor and the Viewer - to keep the main task open.

ld-kerley avatar May 15 '25 17:05 ld-kerley