AcademySoftwareFoundation
Graph Editor : Support Node Up/Down Stream Connection Traversal in Property Editor
Change
Property Editor
- Add in clickable links to traverse through pin connections (inputs / outputs),
- This gives an easy way to move through a graph and also provide information on what is being routed in and out of a node
- Useful for diagnosis (see bugs section below)
- Options: Allow for output connections to be displayed with a per node toggle.
Hot Keys
- Add LEFT and RIGHT arrow hot keys to traverse to up / downstream from a selected node. When multiple connections will choose the first one for now.
Details
Property Editor
- Currently pin connections show the type which gives no information as to what is connected to it. You can hover over the pins in the graph but this just gives you pin names w/o node names
- Instead add in clickable buttons to traverse between pins.
- Traversal includes selecting the centering around selected node
- Fix positioning of "Show all inputs" for
nodegraphs. (missed from a previous submission)
Hot Keys
- Will choose the first up or downstream connected node. Later updates can add in some selection mechanism is desired.
General Fixes
- There are some existing bugs found in the code:
- Deletion does not refresh connections properly
- Inputs to graphs are not properly updating.
- Prevent a possible crash when deleting. Didn't fix the issue
Results
https://github.com/user-attachments/assets/9b3f157e-dbca-44f4-a156-2706a2d0928e
-
Fan-out from an output:
-
Upstream connections:
-
Hide output connections:
-
Hot Key Traversal
https://github.com/user-attachments/assets/e3552d2f-acef-4dca-8e69-7e72db0eda94
Pinging @lfl-eholthouser and @jstone-lucasfilm for comments.
@kwokcb Like so many folks on the MaterialX Slack, I'm interested in the proposed color change, and I wonder if you could separate this out into its own PR, so that we can evaluate these two distinct proposals separately.
This no longer has color background logic. I does do the same traversal discovery required for #2025 though different UI interface.
This has been sitting here for a very long time. Is there interest in adding this in. If not I will close this as I already have this in my own editor.