AmiiBomb-uino icon indicating copy to clipboard operation
AmiiBomb-uino copied to clipboard

Published 20 hours ago • verified publisher icon AcK77

Update MFRC522 Library

Open xrobau opened this issue 7 years ago • 2 comments

As per the comment in https://gbatemp.net/threads/tools-amiibomb.467990/page-27#post-7516237 I updated the MFRC522 library. Seems to work fine.

xrobau avatar Sep 03 '17 19:09 xrobau

However, after viewing the diff, it appears to be missing the 'Magic' section of code here - Does this need to be re-added?

(Note I didn't try writing)

xrobau avatar Sep 03 '17 19:09 xrobau

the magic section was moved to a new file in the upstream library: MFRC522hack.h being that it is for "hackable" cards that aren't within the spec, so the library was moved to a "hackable" library that also doesn't follow the spec.

Since amiibomb doesn't currently use any of the MAGIC functions for resetting UID cards, its fine to leave out for now, at some point if/when the "reset hackable cards" feature is added to amiibomb then the MFRC522hack library can be added then.

I've built successfully with the updated lib, and without the hack.h file.

I don't think the MFRC522debug library should be included though, IMO.

peacepenguin avatar Sep 11 '17 21:09 peacepenguin