LanguageManager-SwiftUI icon indicating copy to clipboard operation
LanguageManager-SwiftUI copied to clipboard

Use languages other than enum Languages

Open NewestUser opened this issue 3 years ago • 4 comments

Is there a way to set the language of the app to a language other than the ones that are defined in Languages. For example I would like to change the language to Bulgarian or Serbian?

NewestUser avatar May 18 '22 16:05 NewestUser

I suggest you make a PR to the repo with the changes you want, or install the library manually and add the changes manually in your project.

AmrKoritem avatar Aug 29 '22 19:08 AmrKoritem

@NewestUser Can you create a pull request with the new languages you want to add? I'm keeping them as enum for multiple reasons:

  • Not to make a mistake by passing a string with a typo.
  • It will be easier to use.

Abedalkareem avatar Jan 04 '23 04:01 Abedalkareem

Can anyone create a pull request adding the Bulgarian and Serbian languages?

Abedalkareem avatar Jan 04 '23 05:01 Abedalkareem

Serbian was just an example. In reality currently I need Bulgarian and Macedonian which just highlights the limits of the enum definition. IMO it would be nice to have a few mainstream languages defined as an enum but also provide the ability to pass strings. If a typo is made then it will be up to the developer to fix that typo, at the end he will notice that the language isn't working as expected and he will be forced to track down the typo and fix it.

Can anyone create a pull request adding the Bulgarian and Serbian languages?

Unfortunately I currently can't dedicate time to this.

NewestUser avatar Jan 04 '23 10:01 NewestUser