Abe Jellinek

Results 189 comments of Abe Jellinek

Yeah, I'd love to work on this but it looks like it's restricted to UK institutions.

Thanks, a couple things: 1. I don't think this should be an import translator at all. Just keep the web part and make the JSON translation routine internal. We don't...

OK, looks like the huge file size is coming from the second test. A few issues contributing: 1. We need to call `selectItems()` on search results pages. The translator shouldn't...

This should be a web translator and should support both search results and individual item pages. A site's size isn't an argument for making its JSON schema into an import...

> That JSON is too weird to be a standard, it should be based in some local setting. Why? It seems like a standard feature according to that page... What...

Excellent, thanks! Could you find an ebook that this works for and post the permalink here? Tests for EBSCOhost are a nonstarter, but I'd like to give it a try...

Huh, it's not returning any items for me. It seems like ebook catalog pages already worked - is this just for when you're in the reader?

Sounds good, thanks.

What a pain. I'm not seeing it working on my end, but I also can't view that exact item - I don't think my library has access to it. Could...

Alright, I took a stab at addressing some of @zuphilip's comments on this, but I can't push to the `ndl-periodicals` branch. @fbennett, could you see if you can enable maintainer...