RootPainter3D icon indicating copy to clipboard operation
RootPainter3D copied to clipboard
verified publisher icon Abe404

Add support for .nii files

Open Abe404 opened this issue 3 years ago • 3 comments

See https://github.com/Abe404/RootPainter3D/pull/9#issue-1349894403

Andre wants to test the software with .nii files. I think that it's probably easy to add support for this considering we already support compressed nifty (nii.gz).

Abe404 avatar Aug 24 '22 20:08 Abe404

Made a PR https://github.com/Abe404/RootPainter3D/pull/11.

andreped avatar Aug 25 '22 07:08 andreped

I have fixed it I think. See https://github.com/Abe404/RootPainter3D/compare/master...nii-support The branch is: https://github.com/Abe404/RootPainter3D/tree/nii-support

I think it makes sense to test this before merging to master and closing the issue.

Abe404 avatar Aug 25 '22 08:08 Abe404

Absolutely, please, test that this works before merging :P

Ideally we should have some unit tests for this, but it can be quite tedious to setup for such a huge project. Hence, I would recommend you just testing stuff out yourself, as you normally would.

andreped avatar Aug 25 '22 09:08 andreped