shopcube icon indicating copy to clipboard operation
shopcube copied to clipboard

Add .example.env with some private config examples

Open Abdur-rahmaanJ opened this issue 4 years ago • 3 comments

Add to shopyo/ (root level) the file .example.env with the content as bellow:

SECRET_KEY = "iMUutJJvkH5vcucaU6xF"
MAIL_USERNAME = "[email protected]"
MAIL_PASSWORD = "pass"
MAIL_DEFAULT_SENDER = "[email protected]"
SQLALCHEMY_DATABASE_URI = "mysql+pymysql://db_username:db_password@db_host/db_name"

Abdur-rahmaanJ avatar Mar 02 '21 05:03 Abdur-rahmaanJ

@Abdur-rahmaanJ instead of adding commented out code (not good) we can add an example environment with this config like this https://github.com/Abdur-rahmaanJ/shopyo/blob/dev/shopyo/.test.prod.env at root level

rehmanis avatar Mar 02 '21 05:03 rehmanis

@rehmanis Commented out code for configs is quite popular in the PHP world. Yes this sounds fine too. Could you create a new secrets.rst explaining the instance folder as well as .text.prod.env's purpose?

Abdur-rahmaanJ avatar Mar 02 '21 05:03 Abdur-rahmaanJ

sure will do. It is just to make code easy to read is all and keep things clean.

rehmanis avatar Mar 02 '21 05:03 rehmanis