greenberry icon indicating copy to clipboard operation
greenberry copied to clipboard

Fix run error

Open Abdur-rahmaanJ opened this issue 2 years ago • 12 comments

  • [ ] The project must run without errors in output

Abdur-rahmaanJ avatar Oct 02 '22 05:10 Abdur-rahmaanJ

Hey, can you give more details about the errors? I did python -m pip install greenberry and it gave me no errors. Running a basic .gb file doesn't give any errors either.

0xGodspeed avatar Oct 02 '22 06:10 0xGodspeed

@0xGodspeed output does not correspond with instructions

Abdur-rahmaanJ avatar Oct 02 '22 06:10 Abdur-rahmaanJ

I am really sorry but I still can't find the error. Could you please tell me what command gives the wrong output? image

0xGodspeed avatar Oct 02 '22 06:10 0xGodspeed

@0xGodspeed Sorry you must install green berry using python -m pip install -e .

Abdur-rahmaanJ avatar Oct 02 '22 07:10 Abdur-rahmaanJ

I believe this is the problem https://github.com/Abdur-rahmaanJ/greenberry/blob/a94e6ba2dd4836bad6b883acd8cd775c5a71a6c0/setup.py#L90 And this seems to fix it:

 packages=find_packages('src'), 

I'm not exactly sure how setuptools works and why it searches for the tests directory in src/ without this. Please explain to me if you can.

0xGodspeed avatar Oct 02 '22 08:10 0xGodspeed

@0xGodspeed You have an interesting problem which this issue does not describe, how did you encounter the test error?

Abdur-rahmaanJ avatar Oct 02 '22 09:10 Abdur-rahmaanJ

by doing python -m pip install -e

0xGodspeed avatar Oct 02 '22 10:10 0xGodspeed

@0xGodspeed Ok open a PR to fix it!

Abdur-rahmaanJ avatar Oct 02 '22 10:10 Abdur-rahmaanJ

@Abdur-rahmaanJ Is it unrelated from this issue? Should I mention this issue in the PR?

0xGodspeed avatar Oct 02 '22 10:10 0xGodspeed

Yes, just add an orphan PR

Abdur-rahmaanJ avatar Oct 02 '22 10:10 Abdur-rahmaanJ

Hi all,

I'd like to contribute to this project, but noticed that the last issue is added a year ago. Is this project still alive?

BernardVos avatar Sep 12 '23 09:09 BernardVos

@BernardVos Well, i am all the time available, if you need anything, ping me. If you need a Google meet, mail me: arj.python at gmail.com.

Abdur-rahmaanJ avatar Oct 10 '23 07:10 Abdur-rahmaanJ