Auto-Photoshop-StableDiffusion-Plugin icon indicating copy to clipboard operation
Auto-Photoshop-StableDiffusion-Plugin copied to clipboard

Refactor ControlNet tab to compat ControlNet1.1

Open zombieyang opened this issue 1 year ago • 2 comments

  1. support cn1.1's Threshold A/ Threshold B. Which is high demand by some new controlnet like 'tile'.
  2. support cn1.1's new ControlMode, which will replace guessmode.
  3. support cn1.1's new pixel perfect. We will use it by default.
  4. keep compat with cn1.0.
  5. refactor the tab to use React and Mobx.

It's a big PR, and it is tested by me for 2 days. I'll keep testing it. especially the compatibility with cn1.0. If you meet any bug or have some suggestion, you can contact me in Discord.

zombieyang avatar May 02 '23 18:05 zombieyang

Hi Yang,

I’m still interested in merging this PR. Let me know if you still have time to work on it. Here’s a list of things that need more work before I can merge it (I can help you work on these):

  • Match the ControlNet features that are currently present in the main branch. There is no need to rewrite the ControlNetUnit component, just add the feature sets that are currently present.
  • Refactor webpack.config.js and tsconfig.json with the one present in ultimate sd upscale and place them in the root directory
  • Remove the built artifact files from the commit. Any file that is either transpiled by TypeScript or bundled by webpack
  • Add instructions on how to build the project.

AbdullahAlfaraj avatar May 24 '23 12:05 AbdullahAlfaraj

Hi Yang,

I’m still interested in merging this PR. Let me know if you still have time to work on it. Here’s a list of things that need more work before I can merge it (I can help you work on these):

  • Match the ControlNet features that are currently present in the main branch. There is no need to rewrite the ControlNetUnit component, just add the feature sets that are currently present.
  • Refactor webpack.config.js and tsconfig.json with the one present in ultimate sd upscale and place them in the root directory
  • Remove the built artifact files from the commit. Any file that is either transpiled by TypeScript or bundled by webpack
  • Add instructions on how to build the project.

I'm so busy these day and i'm afraid that I won't have enough time to finish that until later June.

And I notice you have a React+Mobx stack since 1.2.5, so I think it is better to build these code with your build pipeline, so you can do what you want and I will help to test the code.

zombieyang avatar May 24 '23 15:05 zombieyang

Can we add a check button that will automatically update and set a new controlnet reference that matches the selection marque during generation?
I dont know how to post a new request, sorry.

Absinthze avatar May 29 '23 21:05 Absinthze

#308

zombieyang avatar Jun 24 '23 15:06 zombieyang