flutter_typeahead icon indicating copy to clipboard operation
flutter_typeahead copied to clipboard

feat: add itemBorderRadius and wrap itemBuilder with IgnorePointer

Open coder-with-a-bushido opened this issue 9 months ago • 3 comments

Description

Fixes https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/585 Fixes https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/586

This PR does 2 things:

  1. Adds a new property itemBorderRadius which will be applied on the default itemBuilder that is wrapped on the itemBuilder passed by the user.
  2. Wraps the itemBuilder passed by the user with an IgnorePointer so that the interaction behaviour (ex. mouse hover) of the wrapping default itemBuilder is not affected. This shouldn't really change much for the user as any onTap or onPress event from the passed itemBuilder is being ignored already due to the default itemBuilder.

Checklist

Please check if your PR fulfils the following requirements:

  • [x] I have read the Contributor Guide
  • [x] I have filed an issue for the change
    [#Issue Number]
  • [x] All code is formatted with dartfmt
  • [x] All code passes analysis with no errors or warnings
  • [x] Changes work for both Material and Cupertino
  • [x] New code has documentation where needed
  • [x] New code has test coverage if applicable
  • [x] All existing tests pass
  • [x] Example project still compiles and runs
  • [x] Changes have been documented in CHANGELOG.md
    Using the Keep A Changelog format.
    You may use cider to help with this.
  • [x] New code has been documented in the README.md if applicable
  • [x] Commit messages follow the Conventional Commits format

coder-with-a-bushido avatar May 15 '24 02:05 coder-with-a-bushido