AbdBarho
AbdBarho
Related #159 #676 #812
I do agree with the 'rebase first' approach, and I also agree that too many conflicts that make rebases hard usually means the PR is way too big. Perhaps one...
@sryu1 thanks for the suggestion. > I doubt this would be possible as this probably will be extremely hard and quite different to Open-Assitant Could you please elaborate on this?
> I see you marked this as draft. Will approve once you set it to ready for review again. I don't want to unset draft because I am not able...
@Jac-Zac great! So the problem is that there are missing dependencies which needs to be installed, but before we do that, we can simplify the config file: ```json { "root":...
@Jac-Zac Great! You can see that it is working because the pipeline fails and eslint shows errors https://github.com/LAION-AI/Open-Assistant/actions/runs/3796227051/jobs/6456127814#step:4:143 I will discuss with the team how to move forward with this...
@Jac-Zac Thank you for the contribution! ❤ I did some small changes in #142, and also addressed what @fozziethebeat mentioned. Your work is preserved: https://github.com/LAION-AI/Open-Assistant/commit/71e260ec52478ea096f5b73bd8997670b1cb10ac
@Jac-Zac thanks! we welcome all contributions. For the backend, we already have [pre-commit hooks](https://github.com/LAION-AI/Open-Assistant/blob/main/.pre-commit-config.yaml) that should guarantee formatting with `isort`. However, this issue covers the typescript code for the website,...
@Jac-Zac great! could you please replace or extend this file? https://github.com/LAION-AI/Open-Assistant/blob/main/website/.eslintrc.json