Aaron Stannard

Results 693 comments of Aaron Stannard

@Arkatufus https://stackoverflow.com/a/7455860/377476 Basically the `GC.TotalMemory` only measures memory allocated onto the heap via the garbage collector - any unmanaged memory, stack memory, and so on can't be measured there. Might...

What about what I suggested above @Arkatufus ? Avoiding perf counters is a good idea given that they aren't x-plat - want some sort of abstraction that works on all...

https://github.com/akkadotnet/akka.net/blob/a69d7787a223c4f60ecbe6d7e46897fe6f42ff19/src/contrib/cluster/Akka.Cluster.Metrics/Collectors/DefaultCollector.cs#L62 - we should probably not be forcing full GC here each time we sample. No bueno. Just need to report on what current usage looks like, not have any...

https://github.com/akkadotnet/akka.net/blob/a69d7787a223c4f60ecbe6d7e46897fe6f42ff19/src/contrib/cluster/Akka.Cluster.Metrics/Collectors/DefaultCollector.cs#L64 - this value measures only virtual memory. Definitely not what users are interested in - we should have three separate memory counters: 1. Process.WorkingSet64 - allows us to capture...

What's the difference between `Process.WorkingSet64` and `Environment.WorkingSet`? https://learn.microsoft.com/en-us/dotnet/api/system.environment.workingset?view=netstandard-2.0#system-environment-workingset Both APIs are available in .NET Standard 2.0.

Are we calling `Process.Refresh()` during sampling intervals? https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.process.refresh?view=netstandard-2.0#system-diagnostics-process-refresh

CPU numbers look good x-plat on both of the tested platforms so far - and the memory tracking issues are consistently off on both platforms, which makes me think it's...

So the only reason our MNTR specs are passing today: https://github.com/akkadotnet/akka.net/blob/8bf4a613d1d9ba4c3424c2283369deb470d3af43/src/contrib/cluster/Akka.Cluster.Metrics/Collectors/DefaultCollector.cs#L61-L64 `process.VirtualMemorySize64` will always return 2.1 TB of memory - which is vastly higher than what most Akka.NET applications will...