Aaron van Geffen

Results 338 comments of Aaron van Geffen

Interesting bug! Does this happen in vanilla as well? I'm not sure we've implemented the relevant routines in C++ yet. We cannot fix this unless that is the case.

The code bases aren't shared directly, but we should certainly be able to implement a similar feature. I think it'll have to wait until all so-called paint functions have been...

We've enabled wall placement generally, so it makes sense to make removal available as well, right.

Hmm, so you're suggesting pausing the music would be made optional. I worry this will make the logic even less transparent than it already is. Part of me prefer we...

Hmm, I honestly think we shouldn't try to 'translate' names at an object level. Personally, I'd like to have, say, a set of Spanish names as a separate object to...

I propose we remove: https://github.com/OpenLoco/OpenLoco/blob/2e15bb6e36aa1e52c020e3fe6642083f6c0703d8/src/openloco/input/mouse_input.cpp#L698-L701 The sound should already be covered by either: https://github.com/OpenLoco/OpenLoco/blob/2e15bb6e36aa1e52c020e3fe6642083f6c0703d8/src/openloco/input/mouse_input.cpp#L629 or https://github.com/OpenLoco/OpenLoco/blob/2e15bb6e36aa1e52c020e3fe6642083f6c0703d8/src/openloco/input/mouse_input.cpp#L943 @marijnvdwerf Your thoughts?

The issue persists for dropdown items.

Some discussion on Discord whether updatingCompanyId should belong to CompanyManager or GameCommands. I initially chose GameCommands, because right now it's mostly being set there. Ultimately, it should just be passed...

Amusing bug. Could you perhaps provide a save game so we can easily reproduce this?

Thanks for the report. Unfortunately, we have barely implemented most of the vehicle and financial code, so we're relying on interopting with the original game code for these things. Eventually,...