go-git-http icon indicating copy to clipboard operation
go-git-http copied to clipboard

auth: Suggestion, use standard library to parse basic auth header.

Open dmitshur opened this issue 9 years ago • 1 comments

Hi,

This is just a suggestion. The file auth/basicauth.go contains func parseAuthHeader(header string) (*BasicAuth, error) to parse basic authentication header.

This functionality is available a part of the Go standard library:

https://godoc.org/net/http#Request.BasicAuth

You could use that instead. That'll allow you to completely remove auth/basicauth.go and its tests.

What do you think of that idea?

dmitshur avatar Jan 06 '16 01:01 dmitshur

Friendly ping @AaronO. Do you have any thoughts on this suggestion?

dmitshur avatar Feb 23 '16 22:02 dmitshur