Aaron Ballman

I don't see how you'd ever get two attributes with different values on the same statement with any sane use of macros, but I can live with the behavior of...

I think the consensus on the issue is that we should do *something* here. I removed myself as Assignee because I won't have the bandwidth to work on this myself.

> My intent with changes made for this issue is to (continue to) treat all paths specified by /I as user paths and all paths specified by /external:I, /external:env, %INCLUDE%,...

> Thanks, @AaronBallman, > > > > Ideally, I think we would do the following at some point to improve compatibility with MSVC. > > > > > > I'm...

> > Doesn't that impact whether a header is found via `""` or `` syntax? e.g., if something went from a user header to a system header, I thought that...

> Opinions on whether the current `-fms-compatibility` controlled behavior to search the directories of the include stack for `#include "xxx"` headers should be switched to this new option is welcome....

Thank you for this factoring! Personally, I think this is a good model to go with for factoring functionality out of Sema and adding a tiny bit of layering to...

> Is there anything more I can do on this issue? (I will shortly be unable to do more) It would be super helpful if you were able to reduce...

> There is a Windows failure that I can't reproduce: https://buildkite.com/llvm-project/github-pull-requests/builds/46331 Can someone help me to figure out what is wrong? I'm not certain what's going on yet, but it...

> > > > > There is a Windows failure that I can't reproduce: https://buildkite.com/llvm-project/github-pull-requests/builds/46331 Can someone help me to figure out what is wrong? > > > > >...