stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Notifications broken with 3.23 merge

Open space-nuko opened this issue 2 years ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Notifications/sounds no longer trigger on successful generation

This is because auto did not update notifications.js with new element selectors

const galleryPreviews = gradioApp().querySelectorAll('div[id^="tab_"][style*="display: block"] div[id$="_results"] img.h-full.w-full.overflow-hidden');

needs to be

const galleryPreviews = gradioApp().querySelectorAll('div[id^="tab_"][style*="display: block"] div[id$="_results"] .thumbnail-item > img');

(https://github.com/space-nuko/stable-diffusion-webui/commit/c115ff6a6d928eb84a8cf02621f881d1b79caff4)

Steps to reproduce the problem

Generate image

What should have happened?

Notification does not fire

Commit where the problem happens

91ae48f

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

N/A

List of extensions

N/A

Console logs

N/A

Additional information

No response

space-nuko avatar Mar 25 '23 17:03 space-nuko