AUTOMATIC1111
Remove "do not add watermark to images" option
Describe what this pull request is trying to achieve.
I have no idea what this option is supposed to do, at first it confused me when I noticed it in the settings. As it turns out it's dead code. I'd like to remove it to prevent further confusion
Environment this was tested in
List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.
- OS: Windows
- Browser: Chrome
- Graphics card: NVIDIA RTX 3090
Screenshots or videos of your changes N/A
For the record it was always dead code and I think it was intended as a joke. https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/f98338faa84ecce503e68d8ba13d5f7bbae52730
Also this was already denied once. https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/7510
Oh. Well, if it was then the joke was lost on me. Guess that means the value of keeping it in is subjective
Though, it bothers me a bit that a user that doesn't understand such an in-joke and has no knowledge of the underlying code might think it does something, it is presented in the settings UI like a legitimate option after all
https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/7510#issuecomment-1416734443 ¯\ _ (ツ)_/¯
So the default assumption new users of webui are going to have is that webui adds watermarks? How many people would believe this?
I'd expect saying "you can turn off watermarks" is going to make more people believe "oh, so webui adds watermarks then" than previously existed, is all
I understand it no more than you. And about how many would believe this - pretty much all of them except several people who did check the code or an image with presumed WM on.
It's just, as a user I have a reasonable expectation the presented options to have some effect if they're changed. As a thought experiment you could just as easily have a "do not add" option that does the opposite and adds a watermark to troll people. But that almost never happens because by default the users trust the developers not to add a meaningless option
Likewise an option that does nothing seems pretty meaningless from my perspective. That kind of thing shouldn't fly in, say, a Fortune 500 company's app, just for the sake of a psychological effect
Apologies if I come off as a killjoy, but as it stands this app is extremely popular so maybe a note in the readme or wiki/FAQ addressing that would be more appropriate
I'm not voting for keeping it, just as you I have no idea why was it added, previous PR for removing it was mine. The message I linked is obviously just some pretense.
Well yeah, that's really dumb. I assumed it applied some sort of steganographic watermark that wasn't visible to the naked eye to make the images easier to verify as AI-created later, if it does nothing then take out the check box.
I just spent an hour figuring out why my watermark doesn't work and how I can control the content of the watermark - i.e. choose my own watermark with my website. This sucks balls. What an annoyance.
Saw the release notes and became quite curious about this, looks like I was one of the rubes who fell for it lmao
"Actually, it's about ethics in machine learning~"
Shit voldy I got trolled by this as well, came here to check why it got removed. I always assumed it was some poz in the original SD implementation that you'd kindly removed for us!
