stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Fixes xyz extra_generation_params not being saved (previously worked)

Open EllangoK opened this issue 2 years ago • 1 comments

Describe what this pull request is trying to achieve.

As mentioned in the dev discord #8326 breaks saving off metadata for the grid parameters. image

It is because the extra_generation_params are in grid_infotext[0] (for only the main grid, which was an issue they attempted to solve), but #8326 switched it to accessing processed.infotexts which never has the extra_generation_params added to it.

This fixes that by updating grid_infotexts properly with both main and subgrid information, and then overwriting the correct range in processed.infotexts with grid_infotext. Subgrid information is taken from x = 0 and y = 0 as does #8326.

Video shows that in the interface as well there are no alignment issues.

Video

xyz-values

EllangoK avatar Mar 22 '23 05:03 EllangoK

Well that's neat, I was just thinking how useful it would be to have that information saved, and never realized it was previously stored at processed.infotexts[0]

Would it not be easier to just store a master_infotext variable and tack on master_infotext = processed.infotexts[0] around line 235? That's how it handled that information before I got to it, it was just shoving it in the wrong spot.

Edit: Never mind, I'm pretty sure it does not work that way because I'm cloning the stored processed.infotexts[0] over to the respective sub-grids and main grid. My txt2img-grids folder tells me that this info did in fact work correctly before, but looking at my code changes I can not for the life of me figure out what broke it.

DejitaruJin avatar Mar 23 '23 05:03 DejitaruJin