stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Hires.fix is no longer works

Open mylife4aiur5 opened this issue 1 year ago • 8 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

00049-20230315130139-2694756500

After the first crash today, hires.fix never worked.

I tried changing the model, restart WebUI, update to the latest, and more but it never fixed. Something is not right. I checked the live preview and it seems it stopped working or calculating around 50%. I dont see any error messages at all.

Steps to reproduce the problem

Just use hires.fix upscale by 2 or higher.

What should have happened?

It works normally without hires.fix but with hires.fix, it does not. It suppose to work and it worked fine until now. I have no idea why.

Commit where the problem happens

WebUI Hires.fix

What platforms do you use to access the UI ?

MacOS

What browsers do you use to access the UI ?

Apple Safari

Command Line Arguments

Nothing.

List of extensions

Screenshot 2023-03-15 at 1 20 32 PM

Console logs

To create a public link, set `share=True` in `launch()`.
Startup time: 14.2s (import gradio: 1.0s, import ldm: 2.6s, other imports: 0.8s, list extensions: 0.3s, load scripts: 1.7s, load SD checkpoint: 2.6s, create ui: 4.7s, gradio launch: 0.5s).
100%|███████████████████████████████████████████| 20/20 [00:19<00:00,  1.01it/s]
Total prTile 1/2050%|█████████████▌             | 20/40 [00:38<00:18,  1.07it/s]
	Tile 2/20
	Tile 3/20
	Tile 4/20
	Tile 5/20
	Tile 6/20
	Tile 7/20
	Tile 8/20
	Tile 9/20
	Tile 10/20
	Tile 11/20
	Tile 12/20
	Tile 13/20
	Tile 14/20
	Tile 15/20
	Tile 16/20
	Tile 17/20
	Tile 18/20
	Tile 19/20
	Tile 20/20
100%|███████████████████████████████████████████| 20/20 [05:03<00:00, 15.18s/it]
Total progress: 100%|███████████████████████████| 40/40 [06:25<00:00,  9.63s/it]

Additional information

Using Mac.

mylife4aiur5 avatar Mar 15 '23 17:03 mylife4aiur5

Which upscaler? Which sampler? What other settings?

PestToast avatar Mar 15 '23 23:03 PestToast

Which upscaler? Which sampler? What other settings?

All upscales and samplers. I even re-installed WebUI again and yet, it happened again. Something is not right.

mylife4aiur5 avatar Mar 16 '23 03:03 mylife4aiur5

Which upscaler? Which sampler? What other settings?

Screenshot 2023-03-15 at 11 45 36 PM

I can confirm that even if I re-install, it still happens. This time, I did not download any extensions so something is not right. The only change would be updating macOS to the latest: Ventura 13.2.1

mylife4aiur5 avatar Mar 16 '23 03:03 mylife4aiur5

Correct, macOS 13.2.1 is the problem. Unfortunately this means there isn't really much I can do about this, as this has already been reported to the PyTorch developers (see pytorch/pytorch#95188) and the issue was closed after determining that the bug was at the OS level and fixed in macOS 13.3 beta. This means that the only options currently are to use macOS 13.1, macOS 13.3 beta, or use CPU (which isn't really practical for the larger image sizes affected).

brkirch avatar Mar 17 '23 08:03 brkirch

Try this: Settings > Compatibility > and check the option 'For hires fix, use width/height sliders to set final resolution...'

ostap667inbox avatar Mar 19 '23 01:03 ostap667inbox

Try this: Settings > Compatibility > and check the option 'For hires fix, use width/height sliders to set final resolution...'

Nope, didnt work. Still getting a same issue.

mylife4aiur5 avatar Mar 19 '23 03:03 mylife4aiur5

Update:

Sampler Eular a works totally fine but I guess DPM doesn't work. All Karras dont work.

mylife4aiur5 avatar Mar 22 '23 06:03 mylife4aiur5

From my side even Euler a doesn't work. If the canvas is large enough, an upscale factor that is smaller than 2 doesn't work either. The output image is blurry and not fixed at all.

By the way, even without hires fix, the quality of output is much worse than before (with globally the same prompts) and if the image is sufficiently large, strange things such like blurry or strange colors will appear.

kokoro-aya avatar Mar 22 '23 23:03 kokoro-aya

@mylife4aiur5 @kokoro-aya @925-Studio @Adreitz #8866 has a workaround that will fix generating with higher resolutions on macOS 13.2.X. Some limited testing showed that there may be a ~5% performance penalty in some cases with resolutions >1024x1024. When not using macOS 13.2.X the workaround will not be applied.

brkirch avatar Mar 24 '23 21:03 brkirch

@mylife4aiur5 I didn't notice until after my last comment, but your issue may be caused by more than simply bad output. If you continue to have problems please let me know and I'll reopen this issue.

brkirch avatar Mar 25 '23 06:03 brkirch

@mylife4aiur5 I didn't notice until after my last comment, but your issue may be caused by more than simply bad output. If you continue to have problems please let me know and I'll reopen this issue.

I updated WebUI to the latest and testing several samplers with Hires.fix. I'll let you know within 2 days.

mylife4aiur5 avatar Mar 25 '23 06:03 mylife4aiur5

@mylife4aiur5 I didn't notice until after my last comment, but your issue may be caused by more than simply bad output. If you continue to have problems please let me know and I'll reopen this issue.

So far, I dont notice any issues and I can even do 2.5x upscaling.

mylife4aiur5 avatar Mar 27 '23 02:03 mylife4aiur5

I don't use mac, i use windows 11 and this problem is happening to me for months already, i'm trying to fix and its happening in every single fork. Sometimes generate the preview of the picture, sometimes don't. If have more steps than 25 starts the problem. High resolutions also happen, same for highres fix with high resolution.

RTX 2080 super 8 gb, i9 10900, 32 ram.

FutonGama avatar May 07 '23 11:05 FutonGama

Same issue, just popped up after usage without updating and all upscaling is broken

CRYPTO-GENIK avatar May 13 '23 07:05 CRYPTO-GENIK

Similar problem with infinite Tiles Used R-ESRGAN 4x+ Why is this happening?? Win10

2024-02-17_190339 2024-02-17_190619

JD-Alx avatar Feb 17 '24 16:02 JD-Alx