stable-diffusion-webui
stable-diffusion-webui copied to clipboard
[Feature Request]: Clip adjusting all appropriate settings
Is there an existing issue for this?
- [X] I have searched the existing issues and checked the recent builds/commits
What would your feature do ?
A handful of models require clip 2 set to get them to work properly when you set clip 2 the following changes occur:
22 settings changed: ldsr_steps, ldsr_cached, SWIN_tile, SWIN_tile_overlap, CLIP_stop_at_last_layers, sd_lora, lora_apply_to_outputs, control_net_model_config, control_net_model_adapter_config, control_net_detectedmap_dir, control_net_models_path, control_net_max_models_num, control_net_model_cache_size, control_net_control_transfer, control_net_no_detectmap, control_net_detectmap_autosaving, control_net_only_midctrl_hires, control_net_allow_script_control, control_net_skip_img2img_processing, control_net_monocular_depth_optim, control_net_only_mid_control, control_net_cfg_based_guidance.
When you change the settings back to clip 1 the following changes occur:
1 settings changed: CLIP_stop_at_last_layers.
This results in a DRASTICALLY lower quality of generations once you switch back to clip 1. Possibly even a worse quality at clip 2 due to the initial 22 settings being changed.
Proposed workflow
- Cache the settings as a default for clip 1
- When switching to clip 2 change everything the same way it does
- When switching back to clip 1 restore the default settings cached
Additional information
No response
I think what actually happens here is that those are new settings, currently at their defaults. When you hit "save", it saved their current values (the default) as "the user has set these values".
So those other settings are nothing to do with you changing the clip skip, but rather that you have (it seems) updated or installed ControlNet since you last saved your setttings.
I'm currently away from my PC so I'm unable to replicate for attachments here but the big issue I'm seeing with this that I'm unable resolve easily is Once I switch back from Clip 2 my quality seems significantly worse. ( totally subjective), but a set seed and prompt and settings (all the things) made on clip 1 will give me a repeatable output. If I switch to clip 2 I will continue to get an all be it different output, still repeatable on clip 2. If I switch back to clip 1 the output will be considerably different from the initial clip 1 output as seen prior to all of the 22 settings that changed.
The details are a little ambiguous.. I agree with Xyem about what is seems like, but you'll have to do a bit more investigation.
Changing a setting like that should not affect other settings. So, if that huge list of settings is changing every time, then something unusual is going on for you.
Can you do some more testing in the Settings? Check the ControlNet
settings section before and after you change Clip skip
.
When I change just Clip skip
, it looks like this after I click to Apply:
For example, below are my ControlNet settings -- they stay the same:
Furthermore, make sure that ControlNet is not enabled in the txt2img / img2img tabs.
Maybe a possible theory to explain your poor image quality: If you have ControlNet enabled for output when you see the problem, then whatever problem that's toggling all of ControlNet's options in the Settings would make the result not what you'd expect.
I've moved off A1111 at this point, so I won't be doing further replication tests. However I can give directions on how to replicate, and that may or may not help. I had some config issues pop up and ended up removing my "config.json" file to start from scratch, and noticed my clip 1 images looked a heck of a lot cleaner. After moving to clip 2 all of the settings changed once more, and when I switched back to clip 1 the exact same outputs looked worse. It's very easy to reproduce.