stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Progress bar uses incorrect unicode character

Open zocterminal opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

This is a small and easy to fix glitch.

When the SD software is launched from a unix shell and when the UI generates an image, a progress bar is shown.

This progress bar uses unicode characters to display full and half blocks as progress.

One of these is not rendered correctly in Windows, because instead of a half block (unicode 0x258C), the unicode char to display a 3/4 block (unicode 0x258A) is used.

Steps to reproduce the problem

Use any Linux machine (called sd-server) and install webui there

Use a Windows computer:

  • install ssh Windows feature
  • in a windows command prompt ssh to the sd-server: ssh -i id_rsa user@sd-server
  • start the webui: bash ./webui.sh

Connect a web browser to the guy:

  • http://sd-server:7860
  • generate some image via text2img
  • watch the windows ssh drawing a progress bar
  • at the right side you will see occasional [?] for unknown unicode character

What should have happened?

At the right side a half white block should appear instead of the [?]

Commit where the problem happens

latest

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

./webui.sh listen

List of extensions

independent of extensions

Console logs

60%|███████████████████████████████████████████████████████████▍                                       | 

 63%|██████████████████████████████████████████████████████████████▋                                    

The character at the end of these lines does not render correctly in a shell.  It should be 0x258C instead of 0x258A

Additional information

No response

zocterminal avatar Mar 12 '23 14:03 zocterminal

Upon further inspection, I see the progress bar uses all available 1/8th steps from the unicode page 0x2500, but Windows only supports half steps. So while the implementation is technically correct, maybe rounding down the progress bar to 1/2 would render the progress bar better on windows (also macOS draws weird characters there).

Feel free to close without fixing.

zocterminal avatar Mar 12 '23 14:03 zocterminal