stable-diffusion-webui
stable-diffusion-webui copied to clipboard
AUTOMATIC1111
Use emojis for extra network buttons
Describe what this pull request is trying to achieve.
Use emojis for the extra network UI buttons, so they take up less space: 🔄 for refresh - this emoji is chosen as it's consistent with other usages of refresh in Web UI ❌ for close - this emoji is chosen because it seems intuitive
Additional notes and description of your changes
The emojis are declared and assigned similarly to how it's done in ui.py
Environment this was tested in
- OS: Windows 11
- Browser: Chrome, Firefox
Screenshots or videos of your changes
Before and after:
Mobile UI before and after:
Describe what this pull request is trying to achieve.
Use emojis for the extra network UI buttons, so they take up less space: 🔄 for refresh - this emoji is chosen as it's consistent with other usages of refresh in Web UI ❌ for close - this emoji is chosen because it seems intuitive
Additional notes and description of your changes
The emojis are declared and assigned similarly to how it's done in ui.py
Environment this was tested in
- OS: Windows 11
- Browser: Chrome, Firefox
Screenshots or videos of your changes
Before and after:
Mobile UI before and after:
far better i agree
I have such mixed feelings on dropping text from buttons generally, because so often the icons are inscrutable but in this particular case... well, refresh -definitely- should be changed to maintain consistency with the refresh next to checkpoints and style. The red X I'm less keen on as that reads as "delete" to me... as an example windows explorer uses a bin for "put in trash" and an X for "delete permanently". Honestly I'd be tempted to remove the close button entirely and just rely on clicking/touching the icon that opens the extra networks section a second time.
OTOH, the button in that opens the extra networks section is exactly the kind of icon I hate... I ... have no idea what it's supposed to represent, and I would never guess that it does what it does. I wonder if it might be better controlled by moving that button down to where the extra networks are displayed with one of the collapsible cards that extensions use to add sections to the layout.
The red X I'm less keen on as that reads as "delete" to me... as an example windows explorer uses a bin for "put in trash" and an X for "delete permanently". Honestly I'd be tempted to remove the close button entirely and just rely on clicking/touching the icon that opens the extra networks section a second time.
Yeah I agree with this and had the same thought, too, when selecting the emoji. If Auto wants a different emoji or simply to remove the Close button, I can make the change.
As a sidenote, I never use the 'Close' button personally; I simply click 🎴 again.
Change looks nice, just consider this will likely break the icons on Windows 7, 8.1 and similar systems. This matters because even when the web UI is not hosted on such a system, browsers running on that system could access the web UI.
Change looks nice, just consider this will likely break the icons on Windows 7, 8.1 and similar systems. This matters because even when the web UI is not hosted on such a system, browsers running on that system could access the web UI.
Those emoji are already in the UI, so that ship has sailed. (And more importantly, it's not this PR's responsibility to fix it)
The problem for me with replacing Refresh with an emoji, is that it does not act like all other emoji refresh buttons - others refresh something that is explicitly to the left of it, while this Refresh refreshes the whole page below. Close can be removed, I think, and that would result in more space saved according to the screenshot.
No problem. I restored the text on "Refresh" and removed "Close". This achieves the same intent for me, personally. You can change the PR title to something that makes more sense if you merge this.
Desktop:
Mobile:
No problem. I restored the text on "Refresh" and removed "Close". This achieves the same intent for me, personally. You can change the PR title to something that makes more sense if you merge this.
Desktop:
Please do not remove the CLOSE button. What close does is closes the entire extra networks window. I have 80+ Loras and having to scroll down manually after clicking "generate" is a pain.
Please do not remove the CLOSE button. What close does is closes the entire extra networks window. I have 80+ Loras and having to scroll down manually after clicking "generate" is a pain.
Clicking on the 🎴 again also closes the window. I have about 120 LoRa.
Please do not remove the CLOSE button. What close does is closes the entire extra networks window. I have 80+ Loras and having to scroll down manually after clicking "generate" is a pain.
Clicking on the 🎴 again also closes the window. I have about 120 LoRa.
To be entirely fair, I didn't know about this since it is a 'non obvious' feature. I'm sure a lot of other people wouldn't know about it as well. To remove a functional and visible UI element that just does what it says ("CLOSE"), causes confusion.
Yes, in the past I didn't know about it either; someone just brought it up randomly somewhere at some point. Then afterward I started using it in lieu of "Close".
I've already apologized in the other thread about not providing a tooltip or similar UI feedback to inform the user that the button is toggleable.
Yes, in the past I didn't know about it either; someone just brought it up randomly somewhere at some point. Then afterward I started using it in lieu of "Close". I've already apologized in the other thread about not providing a tooltip or similar UI feedback to inform the user that the button is toggleable.
@Kilvoctu Please do not apologize, you have done nothing wrong. I appreciate your work and that of others. Users provide feedback on what they perceive, and there's a good way to go about it, AND also appreciate that the devs are doing this in their own time and without remuneration.
On desktop environments the "Close" button is more visible than 🎴 and closer to the label, so it's easier to use.
Can anyone add a function to clear the filter when switching model categories, it can save some operations.
