stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Overriding Eta with override_settings once in a custom script, will mess infotext when it's no longer overridden

Open Z-nonymous opened this issue 2 years ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

I have a custom script that takes some input (list of PNG info data from a txt file or from a list of images), i.e.

nice image
Negative prompt: ugly
Eta: 0.3, ENSD: 31337, Seed: 123456789

Let's say I have three PNG entries in my list to batch with :

  • first has Eta not specified
  • second has Eta: 0.3
  • third has Eta not specified

If the global setting for eta_ancestral is 1 (default), then the images generated will have this in PNG info: Eta not set, Eta: 0.3, Eta: 0.3 BUT the third image is correctly generated without Eta: 0.3... I can see that image is similar to the first, not the second.

If the global setting for eta_ancestral is 0.5, then the images generated will have this in PNG info: Eta: 0.5, Eta: 0.3, Eta: 0.5 Which is correct, and the files are correct.

I've looked into it and can't figure out what is happening. ENSD works perfectly fine. The problem is with Eta.

I'm using create_override_settings_dict() to set ENSD and Eta. It works for ENSD, the result and textinfo is always fine. But for Eta the textinfo gets wrong when having default Eta to 1 if Eta was overriden once previously.

If I run the script again, the first image is still good without Eta: 0.3.

Steps to reproduce the problem

I made an easy way to reproduce using a custom script that uses fixed hard coded input. eta_debug.zip

  1. Use script eta_debug.py (shows as eta DEBUG script)
  2. Run script
  3. Check PNG info for the 3 generated images

the third one will have wrong Eta:0.3 (but image has been properly processed without Eta)

  1. Change eta (noise multiplier) for ancestral samplers (i.e. 0.5) in Sampler settings, save settings
  2. Run script
  3. Check PNG info for the 3 generated images

the last image will have the proper Eta.

What should have happened?

The PNG info in the thrid image should not containt Eta: 0.3

Commit where the problem happens

0cc0ee1bcb4c24a8c9715f66cede06601bfc00c8

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--xformers

List of extensions

None

Console logs

Nothing there.

Additional information

No response

Z-nonymous avatar Feb 20 '23 20:02 Z-nonymous