stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

allow flexible image formats for previews

Open vladmandic opened this issue 2 years ago • 4 comments

allow flexible image formats for previews (embeddings, hypernetworks, checkpoints, loras)

vladmandic avatar Feb 12 '23 15:02 vladmandic

Is this needed?

AUTOMATIC1111 avatar Feb 19 '23 07:02 AUTOMATIC1111

It has a major performance impact due to file sizes - my generated previews are grids in high resolution so I can also look at them in details separately.

For example, 100 models/embeddings/etc = 100 x10mb png (1gb just for previews) files that need to be fetched over network VS 100 x 0.5mb jpg files.

network cost saving of jpg vs png is huge and hosting webui on a non-local system is a major thing.

vladmandic avatar Feb 19 '23 13:02 vladmandic

network cost saving of jpg vs png is huge and hosting webui on a non-local system is a major thing.

Could webp be used? It's even better than jpg.

FullBleed avatar Feb 22 '23 21:02 FullBleed

@FullBleed this PR already has webp support

Skeula avatar Feb 26 '23 01:02 Skeula

another PR removed a fair bit of duplicated code and rather than try and merge this and it I ultimately decided to reimplement the functionality; hope this is ok with you.

AUTOMATIC1111 avatar Mar 11 '23 12:03 AUTOMATIC1111

@AUTOMATIC1111 as long as functionality is there, i'm not married to my code :)

vladmandic avatar Mar 11 '23 13:03 vladmandic