[Bug]: Prompt editing steps are wrong with separate hires fix steps

[SirVeggie]

Is there an existing issue for this?

• [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Scenario: Generating an image at 50 steps, 10 highres fix steps.

If the prompt includes [cat:frog :0.2], the word cat changes to frog at 10 step mark. However during highres fix stage instead of changing at 2 step mark, it changes at 10 steps as well.

Steps to reproduce the problem

1. prompt: [cat:frog :0.2]
2. steps 50
3. fix seed in place
4. generate image
5. enable highres fix at 10 steps, 0.6 denoise
6. generate another image
7. highres fix image is clearly more cat than the previous image

What should have happened?

When using percentage with prompt editing, it should be recalculated at the start of highres fix for the edit to occur in the correct position.

Commit where the problem happens

ff6a5bcec1ce25aa8f08b157ea957d764be23d8d

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Brave

Command Line Arguments

--xformers

Additional information, context and logs

[guzuligo]

I was about to report same problem. I guess Hires timer resets when Hires starts working.

Maybe there should be a checkbox to choose to reset or not.

[catboxanon]

Would be resolved by https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/12350

This is also technically not a bug so I've reworded this and swapped the issue label.

[rubberbaron]

#12350 has been superseded by #12457. That change will make this kind of irrelevant.

For what it's worth, though, the code as of now (without #12457) does recompute the hires schedule to account for hires steps, so the change for [:0.2] does occur 20% through, e.g. 2 steps with 10 hires steps. Therefore the original bug reported here seems to have been fixed at some point.