[Bug]: Inpainting and SD upscale don't work together

[wojteksosnowski]

Is there an existing issue for this?

• [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Although SD Upscale passes provided mask to renderer but it is not split. Instead the mask is applied to each grid tile in original size.

Steps to reproduce the problem

1. Go to img2img/inpainting
2. Provide image and mask, and choose whichever parameters desired.
3. Choose script SD Upscale and it's parameters.

What should have happened?

The provided mask should be treated in the same way as base image, split into tiles and applied accordingly.

Commit where the problem happens

commit: 29fb5327

What platforms do you use to access UI ?

MacOS

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

none

Additional information, context and logs

No response

[wojteksosnowski]

Pity it doesn't get any attention.

[wojteksosnowski]

I wonder if ever someone will look at this bug.

[wojteksosnowski]

It still doesn't work.

[catboxanon]

What you're trying to do doesn't really make sense. The linked PR didn't get merged because "fixing" this simply creates seams in the final result. You should first inpaint, then upscale. It's impossible to do both at once due to the SD Upscale script working in tiles.

[felipebottega]

@catboxanon If you inpaint first the upscale probably will destroy your work, so you'll have to inpaint again but with a larger image. Furthermore there is no guarantee that the same parameters with the larger image will reproduce the previous inpainting.

[catboxanon]

Well creating seams isn't going to help.