[Bug]: InPainting runs on default sampler

[malcolmamal]

Is there an existing issue for this?

• [X] I have searched the existing issues and checked the recent builds/commits

What happened?

I've pulled the repo after a week or two and noticed the following problem:

In the InPainting the sampler choice does not work anymore - it will always use the same one (default?).

This can be verified by running Euler A and Heun at 150 steps. The first clue is that if you have a sampler in the name path then the sampler part will show '[sampler]' instead of 'Euler A' or 'Heun'. The second clue is that the time to generate both samples is pretty much the same (normally Heun is twice as slow as Euler A), but the most conclusive clue is that the content of the files is the same.

When I switch back to the commit from some day ago: 30b1bcc64e67ad50c5d3af3a6fe1bd1e9553f34e then this works fine. The Heun works longer and produces different content.

Steps to reproduce the problem

1. checkout master
2. user InPainting, select any sampler, click Generate, select another sampler and Generate
3. the result is the same and the sampler in the path name tells us [sampler] instead of sampler's name
4. checkouting to branch 30b1bcc64e67ad50c5d3af3a6fe1bd1e9553f34e and rerunning step 2 has the following result:
5. the filename properly recognized the specific sampler, the generation times differ as well as the content.

What should have happened?

The proper sampler should have been used. Currently it seems that always the same one is used (default?)

Commit where the problem happens

ff35ae9abb0e2d680bd881e219baf6c998019a9a

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

COMMANDLINE_ARGS=--port 27016 --vae-path models/VAE/vae-ft-mse-840000-ema-pruned.ckpt --no-half-vae

Additional information, context and logs

No response

[chromesun]

Was getting same behaviour for inpaint on build 47a44c7. Reverted to build f1bdf2b, the step just before "change StableDiffusionProcessing to internally use sampler name instead of sampler index". Re-ran gens and, yes, inpaint had been using Euler A instead of my selected Euler. With the reversion to f1bdf2b different samplers generate different images for me again and I'm now getting the sampler name in my output files instead of "[sampler]".

[Hangover3832]

I quick fixed this issue in img2img.py:

[malcolmamal]

I quick fixed this issue in img2img.py:

I'm not seeing this in the repo nor a pull request, will you make one? :-)

[Hangover3832]

I'm not seeing this in the repo nor a pull request, will you make one? :-)

Unfortunately I'm not familiar with GIT 😭, so no, i will not

[SingL3]

I try this PR #4910 and I think it fix this.

[malcolmamal]

closing as it is already fixed, thanks!