stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Sampler not working in X/Y Plot

Open 2x-y opened this issue 3 years ago • 16 comments
trafficstars

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Using the sampler names in the X/Y Plot no longer changes the sampler

Steps to reproduce the problem

In txt2img, select the "X/Y Plot" script Set "X Type" to "Sampler" Enter "Euler a,Euler,LMS,Heun,DPM2" Generate the plot

What should have happened?

Images should be generated by each of the samplers in the plot but the selected sampler is used instead.

Commit where the problem happens

Commit hash: ccd73fc186603b626d996b888d628ebb6b1a38d8

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

--xformers --opt-channelslast

Additional information, context and logs

No response

2x-y avatar Nov 19 '22 14:11 2x-y

Yep, experiencing the same problem

Shangooriginal avatar Nov 19 '22 15:11 Shangooriginal

Same here. It worked fine 2 days ago.

djdookie avatar Nov 19 '22 15:11 djdookie

Same here too

frosta95 avatar Nov 19 '22 16:11 frosta95

I thought it was working correctly, as the sampler names changed in the plot. But the resulting image does remain the same, the same sampler is used.

Gerschel avatar Nov 19 '22 18:11 Gerschel

This line needs to be updated as the script was using the sampler index but now the WebUI uses the sampler name.

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/47a44c7e421b98ca07e92dbf88769b04c9e28f86/scripts/xy_grid.py#L77

Change p.sampler_index to p.sampler_name and sampler_index to x

    p.sampler_name = x

MartinCairnsSQL avatar Nov 19 '22 21:11 MartinCairnsSQL

Same. Was using it all night long, but everything was getting laggy, so I restarted the entire service and browser window to clean out RAM. Kept trying to fix it.

Hero Level:

This line needs to be updated as the script was using the sampler index but now the WebUI uses the sampler name.

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/47a44c7e421b98ca07e92dbf88769b04c9e28f86/scripts/xy_grid.py#L77

Change p.sampler_index to p.sampler_name and sampler_index to x

    p.sampler_name = x

DoughyInTheMiddle avatar Nov 20 '22 21:11 DoughyInTheMiddle

Complete fix.

p.sampler_name = sd_samplers.all_samplers[sampler_index].name

Gerschel avatar Nov 20 '22 22:11 Gerschel

Can someone else push it. I had a long week and I keep making stupid mistakes.

Gerschel avatar Nov 20 '22 23:11 Gerschel

Still getting the same problem - X/Y plot generates the same images despite setting different Samplers as one of the dimensions of the plot. I tried to edit xy_grid.py by myself - just made things worse ;)... using a new install of webui from today...

nozoku avatar Nov 23 '22 11:11 nozoku

Still same problem, X/Y generates the same image like the first sampler.

randaller avatar Nov 23 '22 16:11 randaller

Not working here either

image

it generates the same image

SoftwareLogico avatar Nov 23 '22 21:11 SoftwareLogico

same here....

Humanoidme avatar Nov 24 '22 04:11 Humanoidme

same....

satisl avatar Nov 24 '22 11:11 satisl

currently I'm on commit f7dea1341413c42a3b24a1a3711a7f4eba7a3978 , and the problem still exists for now.

SuperMarioSF avatar Nov 25 '22 21:11 SuperMarioSF

I updated the code in my pull request. I did some commenting and refactoring to (hopefully) make it more clear. This time I had some rest and double, triple checked my code.

Gerschel avatar Nov 26 '22 08:11 Gerschel

Same problem. So if I understand correctly fix is in a PR and we are waiting for it to get added?

MIC132 avatar Nov 26 '22 22:11 MIC132