stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Can't disable tiling

Open JSommersKLH opened this issue 3 years ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

Once tiling is enabled, it cannot be disabled.

Steps to reproduce the problem

  1. txt2img tab, enable tiling
  2. generate a batch
  3. disable tiling
  4. generate a second batch
  5. note that images from both first and second batch are tileable

What should have happened?

When disabling tiling, images should no longer be tiled.

Commit where the problem happens

98947d173e3f1667eba29c904f681047dea9de90

What platforms do you use to access UI ?

Windows 10

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

No response

Additional information, context and logs

No response

JSommersKLH avatar Nov 14 '22 05:11 JSommersKLH

~~I can't replicate this; non-tiled images don't tile after I disable Tiling. Tested on 98947d173e3f1667eba29c904f681047dea9de90, Windows, Firefox, img2img, enabling then disabling Tiled. Tested with Batch size 1 and 2.~~

~~Are there any other changes to your setup? Scripts or anything?~~

EDIT: Oh, is this with Batch IMG2IMG? I'll test that now. EDIT2: No, even with Batch img2img, it's still disabling properly. Can you verify with seamless texture checker that the images in question are in fact tiling? Sometimes it just looks that way.

timntorres avatar Nov 14 '22 08:11 timntorres

I am so sorry. As a developer, I should be ashamed of my poor form here. I submitted a bad report. I meant to write txt2img, not img2img. I was a bit tired when I submitted it. My bad!

JSommersKLH avatar Nov 14 '22 16:11 JSommersKLH

And just to confirm, I did in fact check each image in the full-screen tiled display to make sure they were in fact still tiling. I tried reloading the scripts as well as restarting Gradio to no avail. I had to do a full restart of the console app to get it back to non-tiling.

JSommersKLH avatar Nov 14 '22 16:11 JSommersKLH

Hm, tiling still gets disabled for me on txt2img. Confirmed with a sanity check on the apply_circular function, line 108 of sd_hijack.py.

Click to view console log.

image

Can you try adding this line to that part of the code and screenshotting the console?

Click to view added line.

image

EDIT: And in the case it prints CIRCULAR TILING: False but the output STILL TILES.... please upload the offending image with png info enabled as well.

timntorres avatar Nov 14 '22 16:11 timntorres

Roger that. Will try this all today.

JSommersKLH avatar Nov 14 '22 20:11 JSommersKLH

I modified the code as specified, but I was unable to reproduce the issue. If it recurs, I'll submit a new ticket.

JSommersKLH avatar Nov 16 '22 04:11 JSommersKLH