stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Feature Request]: Picklescan as an extension

Open Centurion-Rome opened this issue 2 years ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Add a "picklescan" as an extension to prevent mailware.

Proposed workflow

  1. Install picklescan as an extension from "https://github.com/mmaitre314/picklescan"
  2. Press scan
  3. see results :)

Additional information

No response

Centurion-Rome avatar Nov 11 '22 13:11 Centurion-Rome

what the difference between this and the built-in one?

ClashSAN avatar Nov 11 '22 14:11 ClashSAN

I don't know all A11 internals. Does internal built-in one one also checking in downloaded / attached .ckpt and extensions and shows warning/blocks them? If so, you may close it as redundant.

Centurion-Rome avatar Nov 11 '22 19:11 Centurion-Rome

how about just "pip install picklescan" and then add "picklescan --path models" just above the "call webui.bat" line in webui-user.bat file. This way it's run each time and you can see the results in the command prompt window.

tommcg avatar Nov 15 '22 20:11 tommcg

IMO: not experience users may not be clear. Better would be do it automaticly if "new" model appeared in list to save time if you have maaanyyy models, so there is no need to scan them every time. configurable in "Config" section from WebUI

Centurion-Rome avatar Nov 16 '22 07:11 Centurion-Rome

the standard picke scanner works just fine, so i'm not sure what you want here

I would say the current one is more picky since it does not allow a certain ckpt file to be loaded while picklescan says it's fine

malcolmamal avatar Nov 19 '22 23:11 malcolmamal