stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Bump gradio to 3.9 to fix image clear button.

Open mezotaken opened this issue 3 years ago • 2 comments

Describe what this pull request is trying to achieve.

Fix issue https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/2963 . This went on for 19 days on Windows, extremely annoying. It was an upstream issue but i managed to fix it there and it got merged https://github.com/gradio-app/gradio/pull/2577 and just in time to be packed under 3.9 tag. This nightmare of a problem will be over, finally.

Additional notes and description of your changes

Auto tests are all ok, no visible problems in the ui or extensions. I did not test EVERY feature, though. Been using it for 2 days with bumped version, no issues encountered. I noticed that previous transfer to 3.8 required some changes in this rep https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/95c6308ccd2e075d1fb804f5b98a4f0b07b87b7d , so better to double check.

Commented test_options_write, since it was disabled in the commit b6cfaaa20b81d16a978524c952412cfc4d89a414 a bit after the test itself was added.

Environment this was tested in

  • OS: Windows 10
  • Browser: Chrome
  • Graphics card: NVIDIA GTX 1060 6GB

mezotaken avatar Nov 05 '22 21:11 mezotaken

LOL i thought it was a feature and honestly felt it was very useful because whenever I remove an image I often want to replace it Nonetheless, it should not be a feature so good fix

aliencaocao avatar Nov 06 '22 03:11 aliencaocao

I think it could be a feature, but there was also a bug that prevented from uploading the same picture that was uploaded last time, even after clear.

mezotaken avatar Nov 06 '22 07:11 mezotaken

I bumped the gradio to 3.9 but I am going to reject this PR because you included something entirely unrelated to the PR. Great job on the fix, I also noticed the problem with the button right away but never knew if it was gradio of one of our hacks.

AUTOMATIC1111 avatar Nov 06 '22 20:11 AUTOMATIC1111