stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: New "Save Highres Fix" option does not work as expected + has no metadata

Open TORN-DIR opened this issue 2 years ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

When using the new before highres fix option in settings, it seems to save the first step of the 2nd pass instead of the last step of the first pass (because it has the same resolution) Also the "before-highres-fix" file has no PNG metadata, which would be desireable to have

image Highres fix settings

Steps to reproduce the problem

  1. Enable "Save a copy of image before applying highres fix." in settings
  2. Enable "Upscale latent space image when doing hires. fix" in settings
  3. Enable "Highres. fix" on main page
  4. Render an image

What should have happened?

The "before-highres-fix" file that is created should be identicle to an image rendered with the same settings at the lower resolution before-highres-fix Left is the render Middle is the before highres fix file I got Right is manually lowering the settings down to the firstpass size and rendering again (the desired outcome)

Commit where the problem happens

I downloaded the zip of "d98eacea40c7a40227f36dbea9cf92f90489310b" (Nov 2, 2022, 6:31 EDT)

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

--medvram --always-batch-cond-uncond --opt-split-attention --precision full --no-half --force-enable-xformers --deepdanbooru

Additional information, context and logs

No response

TORN-DIR avatar Nov 03 '22 10:11 TORN-DIR

~~My original implementation had that resize problem but it seems to have been fixed as of eb5e82c.~~

EDIT: Ah, I see now. The resize problem happens with "Upscale latent space image when doing hires. fix" enabled.

timntorres avatar Nov 03 '22 11:11 timntorres

That upscale latent has been broken for a bit now, and with it broken the highres fix option has no purpose for me at least as I generate at anything but 512x512 I get the old pre fix versions of hope or accept 2, or more, things in the picture.

DarkAlchy avatar Nov 03 '22 21:11 DarkAlchy