AUTOMATIC1111
Allow saving "before-highres-fix." Collect three related settings into one setting.
This pull request consists of two parts.
1) Addresses #4028. Allows user to save a copy of image/images before highres fix is applied.
Saving "-before-highres-fix" is tested and works with... ✅Batch count 1, Batch size 1 ✅Batch count 1, Batch size 2 ✅Batch count 2, Batch size 1 ✅Batch count 2, Batch size 2
2) To reduce clutter, instead of adding yet another option save_images_before_highres_fix, I combined three very similar settings -- "save_images_before_face_restoration", "save_images_before_color_correction", and this new one -- into one setting, "save_intermediates," described as "Save copies before doing face restoration, color correction, highres fix."
I believe there are two types of users: those who want a bunch of intermediate copies, and those who only care about the final result. This new setting reflects that and begins to make room for other more important settings.
The new setting is tested and works with... ✅Face restoration. ✅Color correction. ✅Highres fix. ✅Face restoration AND Highres fix (txt2img). ✅Face restoration AND Color correction (img2img). ⚠️New setting still needs translations.
@AUTOMATIC1111 Very well. I reverted to the old settings and added a third, "save_images_before_highres_fix".
possibly instead of as you say cluttering the settings area could it be better for when either option is selected it adds a second check box "save intermittent step" or something like it in here
does this break img2mg
Thank you for checking. This won't happen again.
Since StableDiffusionProcessingTxt2Img and StableDiffusionProcessingImg2Img both inherit from StableDiffusionProcessing, and only the first subclass's sample function needs that extra argument n, my solution is to check the type of p before sample is called.
Another option that keeps the sample functions' parameters identical is to have sample(...) return a tuple (samples before and after highres fix), but that seemed even less clear.