stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Published 20 hours ago • verified publisher icon AUTOMATIC1111

[BUGFIX] Bump gradio's version to 3.8 [ TESTERS NEEDED ]

Open bamarillo opened this issue 2 years ago • 7 comments

This was done to fix the problems with javascript breaking after reloading. Fixing #3971 #3989 #3920

It was a Gradio's bug (PR's link)

Doing this obviously broke something: the progress bar worked differently and it seemed that all functions declared in the _js param should return something.

So this PR does the following:

  1. Bumps gradio's version to 3.8.
  2. Fixes the problem with the duplication of js functions when reloading.
  3. Rewrites the progress bar logic on the UI to use a system based on events.

I tested all I can, but more testing on different environments is needed, please test and report if something doesn't work as it did in the previous version.

bamarillo avatar Oct 30 '22 19:10 bamarillo

Sorry for taking forever to reply. This will be a really beginner question, but how do I grab this version using command-line? Have a bad experience just copying files over so would prefer to do it "the right way".

some9000 avatar Oct 31 '22 08:10 some9000

@some9000 It's easiest to use the github cli https://cli.github.com/manual/gh_pr_checkout

So for this PR it would be gh pr checkout 3999 and git checkout master to revert back

MartinCairnsSQL avatar Oct 31 '22 11:10 MartinCairnsSQL

It's easiest to use the github cli

That was easy indeed, thanks! I will keep that in mind.

@bamarillo Thank you for your work! Seems to function as expected. Reloading through the options menu keeps the scripts alive, which is great! Also appears to load faster... perhaps, not entirely sure.

some9000 avatar Oct 31 '22 12:10 some9000

Also, this has the added benefit of allowing dictionary inputs for gradio fn calls, which can be useful in a lot of scenarios...

d8ahazard avatar Oct 31 '22 23:10 d8ahazard

The reload button currently works. It broke in the aftermath of the commit that reworked "send to" buttons.

AUTOMATIC1111 avatar Nov 01 '22 13:11 AUTOMATIC1111

@AUTOMATIC1111 you ok with us going forward to update to 3.8 or you want to keep it at 3.5? Just to know if I close this or promote it to PR

bamarillo avatar Nov 01 '22 15:11 bamarillo

The UI currently (latest pull) freezes quite frequently on me when running with --listen. It started about a month ago. Sometimes reload helps, sometimes it doesn't. Hopefully 3.8 and this PR fixes the problem!

jnpatrick99 avatar Nov 01 '22 23:11 jnpatrick99