[Bug]: Extras saves images to output folder, even when auto-saving turned off

[Jonseed]

Is there an existing issue for this?

• [X] I have searched the existing issues and checked the recent builds/commits

What happened?

When using the Extras tab, the images are saved to the "extras" output folder, even when the "always save all images" option is unchecked/off in the settings.

Steps to reproduce the problem

1. Uncheck the "always save all images" in settings
2. Go to Extras tab
3. Generate an image
4. Image is saved in "extras" output folder

What should have happened?

Image should not have been automatically saved in output folder if the setting to auto-save is unchecked/off.

Commit where the problem happens

17a2076

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

--xformers --autolaunch --gradio-img2img-tool color-sketch --vae-path "F:\repos\auto111\stable-diffusion-webui\models\Stable-diffusion\vae-ft-mse-840000-ema-pruned.vae.pt" --administrator

Additional information, context and logs

No response

[Jonseed]

I reported this once before in #923. We can close one of them if you like.

[timntorres]

It probably isn't a coincidence the thing lacks a Save button as well. I'll look into this.

EDIT: Hm, seems Extras deliberately lacks a Save button. I wonder why?

EDIT2: From what I can tell, it's because the save_files function is written specifically to save images generated by sd -- it's hardcoded to work with the webui's metadata and stuff. Extras just isn't compatible with it. Probably gotta write a new equivalent function just for Extras?

[timntorres]

The bug itself is a one line spot fix, but I can't get save button working on the Extras tab, unfortunately. I will leave this to someone more experienced than I am.

[catboxanon]

Closing as stale.