stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Fix Chinese language text part

Open MengNianxiaoyao opened this issue 3 years ago • 3 comments
trafficstars

Fix Chinese language text part

MengNianxiaoyao avatar Oct 29 '22 07:10 MengNianxiaoyao

This is not a fix, you replace your translation to the original one, and erase some of the existing translated content

dtlnor avatar Oct 29 '22 07:10 dtlnor

Oppose the merger 你删除了大量现有翻译内容。

batvbs avatar Oct 29 '22 15:10 batvbs

@MengNianxiaoyao hi, I don't know git too well, but that doesn't seem like the correct way.

Some discussion shows:

i hope I'll be able to add people to codeowners fie to make it possible for people working on translations to update just their translation files and nothing else without PRs

So all translators will be able to edit only the one file they need.

ClashSAN avatar Oct 29 '22 17:10 ClashSAN

@MengNianxiaoyao, this seems to be a problematic PR. Can you please restrict the changes to localizations/zh_CN.json only. If you are suggesting alternative translations and fixes, I would encourage you to discuss them with @dtlnor and @bgluminous. They have access to make any changes to this file.

xmodar avatar Oct 29 '22 20:10 xmodar

merge your translate and remove useless file, do not change other scope at this PR

bgluminous avatar Oct 29 '22 20:10 bgluminous

I don't understand what the purpose of this change is. It doesn't particularly improve anything over what is already present; can OP provide an explanation on why they insist these changes be made?

benlisquare avatar Oct 29 '22 21:10 benlisquare

this PR still removed lot of translate part, try merge it first, and do not change any code at translate PR, any different scope change should open different PR

bgluminous avatar Oct 29 '22 21:10 bgluminous